fix: downgrade reflection request logs to debug#79
Merged
mjheilmann merged 1 commit intoelixir-grpc:mainfrom Apr 13, 2026
Merged
Conversation
Contributor
yordis
commented
Apr 13, 2026
- Every gRPC reflection request was logged at `info`, producing high-volume noise during normal operation — a client traversing a service schema with 20+ proto files generates 20+ log lines per connection with no actionable signal.
- Reflection requests are only useful context when actively debugging reflection issues, which is the intent of `debug` level.
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Contributor
Author
|
@mjheilmann I really need this one 😭 I DDoS our load test because of this using |
Collaborator
@yordis ok, though I'm surprised you are running load tests with log level |
mjheilmann
approved these changes
Apr 13, 2026
Collaborator
|
@yordis released Just making sure you know you can also use a local dependency to easily swap this dependency out for a local copy you can modify for one-off things like load tests, this is a useful change but I wouldn't want to block you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.