mix xref unreachable ignores aliases when --no-compile option is used

[dm1try]

Environment

• Elixir version (elixir -v): 1.3.2

Current behavior

$ mix xref unreachable             
lib/some.ex:10: Logger.unreachable/1

$ mix xref unreachable --no-compile
lib/some.ex:10: Logger.unreachable/1
lib/some.ex:11: AliasedModule.start_link/2

AliasedModule is reachable

Expected behavior

Aliases or any other information that was received on the latest compilation should not be ignored.
Or the --no-compile flag should be removed from shared options of xref command. See mix help xref

[ericentin]

@dm1try can you please share your code as well? Thanks for the report!

[dm1try]

@antipax you can use any mix application.
Running on a fresh phoenix app as example:

lala 1.3.2  mix xref unreachable 
lala 1.3.2  mix xref unreachable --no-compile

lib/lala.ex:28: Lala.Endpoint.config_change/2
lib/lala/endpoint.ex:1: Lala.Router.call/2
lib/lala/endpoint.ex:1: Phoenix.CodeReloader.call/2
lib/lala/endpoint.ex:1: Phoenix.Endpoint.Instrument.strip_caller/1
lib/lala/endpoint.ex:1: Phoenix.Endpoint.RenderErrors.__catch__/4
lib/lala/endpoint.ex:1: Phoenix.LiveReloader.call/2
...

[josevalim]

I think the issue is that --no-compile is implying no loading which means
we won't find anything. If we don't compile, maybe we should at least call
"loadpaths"?

On Thursday, July 21, 2016, dm1try notifications@github.com wrote:

@antipax https://github.com/antipax you can use any mix application.
Running on fresh phoenix app as example:

lala 1.3.2 mix xref unreachable
lala 1.3.2 mix xref unreachable --no-compile

lib/lala.ex:28: Lala.Endpoint.config_change/2
lib/lala/endpoint.ex:1: Lala.Router.call/2
lib/lala/endpoint.ex:1: Phoenix.CodeReloader.call/2
lib/lala/endpoint.ex:1: Phoenix.Endpoint.Instrument.strip_caller/1
lib/lala/endpoint.ex:1: Phoenix.Endpoint.RenderErrors.catch/4
lib/lala/endpoint.ex:1: Phoenix.LiveReloader.call/2
...

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#5045 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAlbvydq4vZEqlHfnHjuH2GSLWDyYp-ks5qX5GGgaJpZM4JR6dd
.

José Valim
www.plataformatec.com.br
Skype: jv.ptec
Founder and Director of R&D

[dm1try]

@josevalim btw, the loadpaths task certainly did the trick, thx :)
mix do loadpaths, xref unreachable --no-compile works as expected(does not compile the app and checks refs fine).

[ericentin]

@josevalim I suppose that since --no-compile will result in erroneous results without running loadpaths we should be doing so. Should I do a PR?

[josevalim]

Should I do a PR?

Yes, please. We should just always call loadpaths before compile, regardless if compile is called. :)