Check map updates #10316
Merged
Check map updates #10316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmj
commented
Sep 10, 2020
|
|
||
| assert {:error, | ||
| {:unable_unify, | ||
| {{:map, [{:required, {:atom, :bar}, :dynamic}, {:optional, :dynamic, :dynamic}]}, |
Member
Author
There was a problem hiding this comment.
The downside with using dynamic() for the values is that it shows up in the error messages which could be slightly confusing.
eksperimental
suggested changes
Sep 10, 2020
josevalim
reviewed
Sep 10, 2020
lib/elixir/lib/module/types/expr.ex
Outdated
| arg_pairs = pairs_to_unions(arg_pairs, context), | ||
| dynamic_value_pairs = | ||
| Enum.map(arg_pairs, fn {:required, key, _value} -> {:required, key, :dynamic} end), | ||
| args_type = {:map, dynamic_value_pairs ++ [{:optional, :dynamic, :dynamic}]}, |
Member
There was a problem hiding this comment.
I think we can encapsule the last three lines or so in a function.
josevalim
reviewed
Sep 10, 2020
lib/elixir/lib/module/types/expr.ex
Outdated
| Enum.map(arg_pairs, fn {:required, key, _value} -> {:required, key, :dynamic} end), | ||
| args_type = {:map, dynamic_value_pairs ++ [{:optional, :dynamic, :dynamic}]}, | ||
| {:ok, type, context} <- unify(args_type, map_type, stack, context) do | ||
| {:map, pairs} = resolve_var(type, context) |
Member
There was a problem hiding this comment.
This can return a union if we do: map.foo or map.bar in a guard and then we update the map. So we need to handle this case too.
Member
Author
There was a problem hiding this comment.
It can't return a union yet afaict, not until unions are lifted unification. It's hard to tell how to handle this scenario correctly until they unions are lifted. Did you have anything in mind?
josevalim
reviewed
Sep 10, 2020
Co-authored-by: Eksperimental <eksperimental@users.noreply.github.com>
fertapric
reviewed
Sep 11, 2020
Co-authored-by: Fernando Tapia Rico <fertapric@gmail.com>
josevalim
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.