Skip to content

Use 'gmake' instead of 'make' when compiling deps on NetBSD #10319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 2 commits into from
Sep 11, 2020
Merged

Use 'gmake' instead of 'make' when compiling deps on NetBSD #10319

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19b163d
Use 'gmake' instead of 'make' when compiling deps on NetBSD
alarixnia Sep 11, 2020
696b647
Apply suggestions from code review
josevalim Sep 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/mix/lib/mix/tasks/deps.compile.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ defmodule Mix.Tasks.Deps.Compile do
* `mix.exs` - invokes `mix compile`
* `rebar.config` - invokes `rebar compile`
* `Makefile.win`- invokes `nmake /F Makefile.win` (only on Windows)
* `Makefile` - invokes `gmake` on FreeBSD and OpenBSD, invokes `make`
on any other operating system (except on Windows)
* `Makefile` - invokes `gmake` on DragonFlyBSD, FreeBSD, NetBSD, and OpenBSD,
invokes `make` on any other operating system (except on Windows)

The compilation can be customized by passing a `compile` option
in the dependency:
Expand Down Expand Up @@ -259,7 +259,7 @@ defmodule Mix.Tasks.Deps.Compile do
{:win32, _} when makefile_win? ->
"nmake /F Makefile.win"

{:unix, type} when type in [:freebsd, :openbsd] ->
{:unix, type} when type in [:dragonfly, :freebsd, :netbsd, :openbsd] ->
"gmake"

_ ->
Expand Down