Handle subtypes in map keys #10323
Merged
Handle subtypes in map keys #10323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmj
reviewed
Sep 12, 2020
| do: Enum.any?(args, &has_unbound_var?(&1, context)) | ||
|
|
||
| def has_unbound_var?({:union, args}, context), | ||
| do: Enum.any?(args, &has_unbound_var?(&1, context)) |
Member
There was a problem hiding this comment.
How come we only check unions and types? What about the other complex types?
Member
Author
There was a problem hiding this comment.
I used subtype? as a reference so if something is missing here, it is missing there. What are they? lists and maps?
Member
Author
There was a problem hiding this comment.
We should sit together and document the types and which functions we have to implement for each new type. :)
| def to_union(types, context) when types != [] do | ||
| flat_types = flatten_union(types) | ||
|
|
||
| if :dynamic in flat_types do |
Member
There was a problem hiding this comment.
Are we removing this because of the new def subtype?(_, :dynamic, _context), do: true clause?
ericmj
approved these changes
Sep 12, 2020
Member
Author
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.