Move type warnings #10324
Merged
Move type warnings #10324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer needs to compile modules to test type warnings. Reduces type tests execution time from 1.0s to 0.6s.
ericmj
force-pushed
the
emj/move-type-warnings
branch
from
e6ef0f2 to
023db08
Compare
ericmj
commented
Sep 12, 2020
| expected one of the following fields: foo | ||
| where "map" was given the type map() in: |
Member
Author
There was a problem hiding this comment.
How come we show map() instead of %{foo: integer()} here? Since it failed because of map.bar we should show the actual type instead of simplifying to map() which is a compatible type.
| where "foo" was given the type integer() in: | ||
| # types_test.ex:1 | ||
| <<foo::integer()>> |
Member
Author
There was a problem hiding this comment.
How come we print as <<foo::integer()>> instead of <<foo::integer>>?
Member
There was a problem hiding this comment.
We need to fix Macro.to_string to skip parens on the right side of :: inside <<>> for the built-in identifiers.
josevalim
approved these changes
Sep 13, 2020
Member
josevalim
left a comment
josevalim
left a comment
There was a problem hiding this comment.
LGTM! We should move some of the function call warnings too but we can do it next.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer needs to compile modules to test type warnings. Reduces type tests execution time from 1.0s to 0.6s.