Move printing test seed to beginning of test run#10399
Closed
jrusso1020 wants to merge 1 commit intoelixir-lang:masterfrom
Closed
Move printing test seed to beginning of test run#10399jrusso1020 wants to merge 1 commit intoelixir-lang:masterfrom
jrusso1020 wants to merge 1 commit intoelixir-lang:masterfrom
Conversation
Came across this proposal on the forums to move the seed of the test suite to the beginning of the test run. This was actually something I wished for recently when encountering a weird issue in our codebase which caused all of our non async tests to fail and each synchronous test would take 60 seconds before timing out. With a few hundred synchronous tests this took quite some time for the suite to finish and I wanted to grab the seed to replicate it. https://groups.google.com/g/elixir-lang-core/c/sP8DiY1zMFQ
jrusso1020
force-pushed
the
move-seed-to-beginning
branch
from
d7f9386 to
007f758
Compare
Contributor
|
I think it would be better if ex_unit printed the seed both at the beginning and at the end of the test suite. For instance, if you have a bunch of failing tests, you wouldn't want to scroll all the way back to where tests started just to find the seed (assuming the test run has already finished). For example, Ruby's RSpec does exactly that. |
Member
|
Thanks @jrusso1020 for reminding me of this issue. I have gone with a different approach in 285a6a6. If your test suite gets stuck, ExUnit now intercepts sigquit and it will show which tests have been aborted as well as a summary of the run alongside the seed. :) In any case, thanks for the PRs! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Came across this proposal on the forums to move printing the seed of the
test suite to the beginning of the test run. This was actually
something I wished for recently when encountering a weird issue
in our codebase which caused all of our non async tests to fail and
each synchronous test would take 60 seconds before timing out. With
a few hundred synchronous tests this took quite some time for the
suite to finish and I wanted to grab the seed to replicate it.
https://groups.google.com/g/elixir-lang-core/c/sP8DiY1zMFQ
Example