Fixing bug in Enum.dedup/1 #10886
Merged
Fixing bug in Enum.dedup/1 #10886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Great find, can you please add a test? Thank you! |
Contributor
Author
|
@josevalim sure! Should I introduce a |
Member
|
There is no need, just add a "dedup with stream" and we should be good! |
Contributor
Author
|
Since it is a separate implementation, I just replicated the whole |
ericmj
approved these changes
Apr 9, 2021
Member
|
💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
that referenced
this pull request
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I just noticed that
Enum.dedup/1isn't working properly on non-list enumerables in the 1.12-rc.0.After investigating, I realized this was a bug I introduced myself in a previous PR 🙈.
Really sorry for that.