Add System.shell/2 #10965
Merged
Add System.shell/2 #10965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v0idpwn
reviewed
May 5, 2021
lib/elixir/lib/system.ex
Outdated
| **Important**: Use this function with care. In particular, **never | ||
| pass user input to this function**, as the user would be able to | ||
| execute any code directly on the machine. Generally speaking, |
Contributor
There was a problem hiding this comment.
I think it would be good to mention that this is a "command injection" vulnerability, so the reader has a keyword to search for and better understand the implications.
lib/elixir/lib/system.ex
Outdated
| end | ||
|
|
||
| @doc ~S""" | ||
| Executes the given `command` in the current OS shell. |
Contributor
There was a problem hiding this comment.
Suggested change
| Executes the given `command` in the current OS shell. | |
| Executes the given `command` in the OS shell. |
"current" makes me think that it will read the "SHELL" env var or something similar
fertapric
reviewed
May 5, 2021
Comment on lines
+902
to
+903
| """ | ||
| @spec shell(binary, keyword) :: {Collectable.t(), exit_status :: non_neg_integer} |
Member
There was a problem hiding this comment.
Suggested change
| """ | |
| @spec shell(binary, keyword) :: {Collectable.t(), exit_status :: non_neg_integer} | |
| """ | |
| @doc since: "1.13.0" | |
| @spec shell(binary, keyword) :: {Collectable.t(), exit_status :: non_neg_integer} |
fertapric
approved these changes
May 5, 2021
lukaszsamson
reviewed
May 5, 2021
lib/elixir/lib/system.ex
Outdated
| 'sh -c "' ++ command ++ '"' | ||
|
|
||
| {:win32, osname} -> | ||
| command = '"' ++ String.to_charlist(command) ++ '"' |
Contributor
There was a problem hiding this comment.
no escaping on windows?
Member
Author
There was a problem hiding this comment.
According to the OTP source, no, but we shouldn't be quoting either. So I will update. Thanks! :)
josevalim
commented
May 5, 2021
ericmj
approved these changes
May 5, 2021
Member
Author
|
💚 💙 💜 💛 ❤️ |
josevalim
added a commit
that referenced
this pull request
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.