Keep backwards compatibility on Range and Date.Range

[lukaszsamson]

Fixes #11110
Handles cases not covered by 13ba96b

There are 2 more usages but those look safe. If I understand it correctly they happen only on compile time

• elixir/lib/elixir/lib/kernel.ex

  Line 4071 in 58ca652

  {:%{}, _meta, [__struct__: Elixir.Range, first: first, last: last, step: step]} ->

• elixir/lib/elixir/lib/kernel.ex

  Line 4077 in 58ca652

  %{__struct__: Elixir.Range, first: _, last: _, step: _} ->

[josevalim]

I believe we don't need this clause because it will fallback to the protocol.

[lukaszsamson]

You're right

iex(6)> Enum.reduce(old_range, 0, fn a, b -> a + b end)
55

[josevalim]

Thanks @lukaszsamson, however I believe those changes are not necessary, except for the daterange ones. Can you please keep only them and add some tests? thank you.

[lukaszsamson]

@josevalim I reverted not needed changes and added test coverage

[v0idpwn]

Nitpick for consistency

[v0idpwn]

Suggested change

	%{__struct__: Date.Range, first_in_iso_days: first_days, last_in_iso_days: last_days} =
	%Date.Range{first_in_iso_days: first_days, last_in_iso_days: last_days} =

[josevalim]

We are not pattern matching on range on purpose because those are "old versions" of the range. In theory the pattern works, because we don't check the size, but I would prefer to keep it explicit it is a subset.

[v0idpwn]

TIL, sorry for noise :)

[v0idpwn]

Suggested change

	def slice(
	%{__struct__: Date.Range, first_in_iso_days: first_days, last_in_iso_days: last_days} =
	date_range
	) do
	step = if first_days <= last_days, do: 1, else: -1
	slice(Map.put(date_range, :step, step))
	end
	def slice(
	%Date.Range{first_in_iso_days: first_days, last_in_iso_days: last_days} =
	date_range
	) do
	step = if first_days <= last_days, do: 1, else: -1
	slice(Map.put(date_range, :step, step))
	end

[v0idpwn]

Suggested change

	%{__struct__: Date.Range, first_in_iso_days: first_days, last_in_iso_days: last_days} =
	date_range,
	acc,
	fun
	) do
	step = if first_days <= last_days, do: 1, else: -1
	reduce(Map.put(date_range, :step, step), acc, fun)
	end
	%Date.Range{first_in_iso_days: first_days, last_in_iso_days: last_days} =
	date_range,
	acc,
	fun
	) do
	step = if first_days <= last_days, do: 1, else: -1
	reduce(Map.put(date_range, :step, step), acc, fun)
	end

[v0idpwn]

Suggested change

	# TODO: Remove me on v2.0
	defp size(
	%{__struct__: Date.Range, first_in_iso_days: first_days, last_in_iso_days: last_days} =
	date_range
	) do
	step = if first_days <= last_days, do: 1, else: -1
	size(Map.put(date_range, :step, step))
	end
	# TODO: Remove me on v2.0
	defp size(
	%Date.Range{first_in_iso_days: first_days, last_in_iso_days: last_days} =
	date_range
	) do
	step = if first_days <= last_days, do: 1, else: -1
	size(Map.put(date_range, :step, step))
	end

[v0idpwn]

Suggested change

	# TODO: Remove me on v2.0
	defp empty?(
	%{__struct__: Date.Range, first_in_iso_days: first_days, last_in_iso_days: last_days} =
	date_range
	) do
	step = if first_days <= last_days, do: 1, else: -1
	empty?(Map.put(date_range, :step, step))
	end
	# TODO: Remove me on v2.0
	defp empty?(
	%Date.Range{first_in_iso_days: first_days, last_in_iso_days: last_days} =
	date_range
	) do
	step = if first_days <= last_days, do: 1, else: -1
	empty?(Map.put(date_range, :step, step))
	end

[v0idpwn]

Suggested change

	# TODO: Remove me on v2.0
	def inspect(%{__struct__: Date.Range, first: first, last: last} = date_range, opts) do
	step = if first <= last, do: 1, else: -1
	inspect(Map.put(date_range, :step, step), opts)
	end
	# TODO: Remove me on v2.0
	def inspect(%Date.Range{first: first, last: last} = date_range, opts) do
	step = if first <= last, do: 1, else: -1
	inspect(Map.put(date_range, :step, step), opts)
	end

[josevalim]

💚 💙 💜 💛 ❤️

[Carmen675]

I DONT CODE I SONT KNOW HOW I JUST WANT WHO EVER HAS TAKEN OVER MY PHONE TO PLEASE STOP PUTTING MALWARE ON MY IPHONE AND SLOWLY TURNING MY PHONE INTO A ANDROID THATS GOING TO BE THEIRS. I HAVE HAD NO IDEA SOMEONE WAS DOING THIS TRACKING MY EVERY MOVE, RECORDING MY PHONE CALLS WHEN I USED TO GET THEM NOW NO CALLS OR TEXTS HARDLY ANYTHING AT ALL