Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bin/elixir
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@ while [ $I -le $LENGTH ]; do
set -- "$@" "$1" "$2"
;;
--rpc-eval)
S=3
set -- "$@" "$1" "$2" "$3"
S=1
set -- "$@" "$1"
;;
--detached)
echo "warning: the --detached option is deprecated" >&2
Expand Down
5 changes: 5 additions & 0 deletions lib/elixir/lib/kernel/cli.ex
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,11 @@ defmodule Kernel.CLI do
parse_shared(t, %{config | commands: [{:rpc_eval, node, h} | config.commands]})
end

defp parse_shared(["--rpc-eval" | _], config) do
new_config = %{config | errors: ["--rpc-eval : wrong number of arguments" | config.errors]}
{[], new_config}
end

defp parse_shared(["-r", h | t], config) do
parse_shared(t, %{config | commands: [{:require, h} | config.commands]})
end
Expand Down
18 changes: 18 additions & 0 deletions lib/elixir/test/elixir/kernel/cli_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,24 @@ defmodule Kernel.CLI.RPCTest do
assert elixir('--name #{node}@127.0.0.1 --rpc-eval #{node} "IO.puts :ok"') == "ok\n"
end

test "can be invoked multiple times" do
node = "cli-rpc#{System.unique_integer()}"

assert elixir(
'--name #{node}@127.0.0.1 --rpc-eval #{node} "IO.puts :foo" --rpc-eval #{node} "IO.puts :bar"'
) == "foo\nbar\n"
end

test "fails on wrong arguments" do
node = "cli-rpc#{System.unique_integer()}"

assert elixir('--name #{node}@127.0.0.1 --rpc-eval') ==
"--rpc-eval : wrong number of arguments\n"

assert elixir('--name #{node}@127.0.0.1 --rpc-eval #{node}') ==
"--rpc-eval : wrong number of arguments\n"
end

stderr_test "properly formats errors" do
assert String.starts_with?(rpc_eval(":erlang.throw 1"), "** (throw) 1")
assert String.starts_with?(rpc_eval(":erlang.error 1"), "** (ErlangError) Erlang error: 1")
Expand Down