Improve Error in case of StringIO write with invalid characters#11756
Merged
josevalim merged 1 commit intoelixir-lang:mainfrom Apr 25, 2022
maennchen:string_io_transcode_error
Merged
Improve Error in case of StringIO write with invalid characters#11756josevalim merged 1 commit intoelixir-lang:mainfrom maennchen:string_io_transcode_error
josevalim merged 1 commit intoelixir-lang:mainfrom
maennchen:string_io_transcode_error
Conversation
maennchen
commented
Apr 25, 2022
maennchen
commented
Apr 25, 2022
maennchen
commented
Apr 25, 2022
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mailing list discussion: https://groups.google.com/g/elixir-lang-core/c/RR7nbeHsluQ
This uses the existing
no_translationerlang error to handle transcoding issues. This will not solve the same problem when using a normal file. (Upcoming PR in OTP itself)EDIT: Removed comment about tests since they have been fixed.