Make wording on the DynSup docs more direct #11970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tries to improve (on top of the improvement) the wording on the docs to distinguish that `DynamicSupervisor` (in contrast to `Supervisor`) can **only** start children dynamically. I think this distinction is important because `Supervisor` can also start children dynamically (although the initialization requirements are different). PS.: See whole discussion [here](https://elixirforum.com/t/difference-between-supervisors-and-dynamicsupervisors-what-am-i-missing/48821/5?u=thiagomajesk).
Member
|
Thank you! I have reverted the changes to the second paragraph because I was taught that the "differently from ..., x does this, y does that" should most often be written as "x does this, y does that" for clarity. :) |
Member
|
💚 💙 💜 💛 ❤️ |
Contributor
Author
|
Thanks for the suggestion @josevalim! I think this little sentence change made it even better:
- I Came Looking For Copper And I Found Gold 🙈 |
This was referenced Jul 9, 2022
josevalim
pushed a commit
to elixir-lang/elixir-lang.github.com
that referenced
this pull request
Jul 14, 2022
Ads a small note about the purpose of `Supervisor` and `DynamicSupervisor` based on the previous improvements made elixir-lang/elixir#11970 and elixir-lang/elixir#11973.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to improve (on top of the improvement) the wording on the docs to distinguish that
DynamicSupervisor(in contrast toSupervisor) can only start children dynamically. I think this distinction is important becauseSupervisorcan also start children "dynamically" (although the initialization requirements are different).PS.: See whole discussion here.