Deterministic struct expansion #12418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Feb 18, 2023
lib/elixir/lib/module/types/of.ex
Outdated
|
|
||
| entries = | ||
| for key <- Map.keys(struct.__struct__()), key != :__struct__ do | ||
| for key <- Map.keys(struct.__struct__()) |> :lists.sort(), key != :__struct__ do |
Member
There was a problem hiding this comment.
this one is only going to affect error messages, right? Maybe we should order in the error messages then?
Contributor
Author
There was a problem hiding this comment.
The error message seems to already be sorted here: https://github.com/elixir-lang/elixir/blob/main/lib/elixir/lib/module/types.ex#L257.
I will just fix tests to remove the influence of ordering there: 997e18e
sabiwara
force-pushed
the
deterministic-struct-expansion
branch
from
16bba32 to
997e18e
Compare
Member
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the last fix regarding non-deterministic key order in OTP26 maps.