Don't call formatter on directories #12488
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up today with a custom formatter that we have for json files. Vscode's ElixirLS created a directory called "apps/our_app/.elixir_ls/build/test/lib/phoenix/priv/templates/phx.gen.json" and running
mix formatresulted in the following error:The fact that we're accidentally formatting files from ElixirLS is of course an issue of ours, but with the exception of
:stdin, I'd say we'd only want to ever try to format regular files.