Support precision in NaiveDateTime/DateTime.utc_now #12558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatyouhide
reviewed
May 11, 2023
whatyouhide
reviewed
May 11, 2023
whatyouhide
reviewed
May 11, 2023
Comment on lines
+180
to
+181
| If you want the current time in Unix seconds, | ||
| use `System.os_time/1` instead. |
Member
There was a problem hiding this comment.
I don't think we should say this, because you can use os_time/1 for microsecond/millisecond/nanosecond times as well, and because you can still use utc_now/1 for that?
Member
There was a problem hiding this comment.
This is a standard text we have in all utc_now functions because people often do DateTime.utc_now() |> to_unix :D
josevalim
reviewed
May 11, 2023
josevalim
reviewed
May 11, 2023
josevalim
reviewed
May 11, 2023
josevalim
requested changes
May 11, 2023
Member
josevalim
left a comment
josevalim
left a comment
There was a problem hiding this comment.
Hi @viniciusmuller, I have dropped some comments.
The main idea is too not use truncate and instead generate the correct version upfront. To do this, make utc_now/2 be the "canonical function" and have utc_now/1 call utc_now/2 accordingly.
Co-authored-by: José Valim <jose.valim@gmail.com>
Co-authored-by: José Valim <jose.valim@gmail.com>
Co-authored-by: José Valim <jose.valim@gmail.com>
viniciusmuller
commented
May 11, 2023
josevalim
reviewed
May 11, 2023
josevalim
reviewed
May 11, 2023
Co-authored-by: José Valim <jose.valim@gmail.com>
Co-authored-by: José Valim <jose.valim@gmail.com>
Member
|
💚 💙 💜 💛 ❤️ |
michallepicki
added a commit
to michallepicki/elixir
that referenced
this pull request
May 12, 2023
since elixir-lang#12558 it is also being called with :native as the time_unit
josevalim
pushed a commit
that referenced
this pull request
May 12, 2023
since #12558 it is also being called with :native as the time_unit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for passing a time unit to
NaiveDateTimeandDateTime'sutc_now/1and creates an alternativeutc_now/2that accepts both a custom time unit and calendar.Closes #12557