Fixes to support 0TP27 #13351
Merged
Fixes to support 0TP27 #13351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabiwara
commented
Feb 15, 2024
Comment on lines
-3812
to
-3813
| iex> Enum.unzip(%{a: 1, b: 2}) | ||
| {[:a, :b], [1, 2]} |
Contributor
Author
There was a problem hiding this comment.
I didn't see a relevant test to be added, a one-size map would hide the fact that the keys are misordered, we already have a keyword above...
sabiwara
commented
Feb 15, 2024
| assert Float.ceil(7.5e-3) === 1.0 | ||
| assert Float.ceil(-12.32453e4) === -123_245.0 | ||
| assert Float.ceil(-12.32453e-10) === 0.0 | ||
| assert Float.ceil(-12.32453e-10) === -0.0 |
Contributor
Author
There was a problem hiding this comment.
Was already the case on OTP26, the test was misleading precisely because 0.0 === -0.0 was true
sabiwara
commented
Feb 15, 2024
| case rounding do | ||
| :ceil when sign === 0 -> 1 / power_of_10(precision) | ||
| :floor when sign === 1 -> -1 / power_of_10(precision) | ||
| :ceil when sign === 1 -> -0.0 |
Contributor
Author
There was a problem hiding this comment.
Fixing Float.ceil/2 to match Float.ceil/1 and :math.ceil/1
Contributor
Author
There was a problem hiding this comment.
Actually I'm not sure, we might want to rethink this whole rounding spec.
Here is the current behavior:
Erlang/OTP 26 [erts-14.2.1] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [jit]
Interactive Elixir (1.16.1) - press Ctrl+C to exit (type h() ENTER for help)
iex(1)> for fun <- [:round, :ceil], num <- [-0.0, -0.01], prec <- 0..1, do: IO.puts "#{fun}(#{num}), #{prec}) = #{apply(Float, fun, [num, prec])}"
round(-0.0), 0) = 0.0
round(-0.0), 1) = -0.0
round(-0.01), 0) = 0.0
round(-0.01), 1) = 0.0
ceil(-0.0), 0) = -0.0
ceil(-0.0), 1) = -0.0
ceil(-0.01), 0) = -0.0
ceil(-0.01), 1) = 0.0It feels like we'd want to have to following invariants:
ceil(x) >= round(x)fun(-0.01) <= fun(-0.0)fun(-0.01, 0) === fun(-0.01, 1)
but none of these are currently respected.
How about the following?
round(-0.0), 0) = -0.0
round(-0.0), 1) = -0.0
round(-0.01), 0) = -0.0
round(-0.01), 1) = -0.0
ceil(-0.0), 0) = -0.0
ceil(-0.0), 1) = -0.0
ceil(-0.01), 0) = -0.0
ceil(-0.01), 1) = -0.0Seems consistent with what Javascript and Python are doing:
> Math.round(-0.0, 0)
-0
> Math.round(-0.0, 1)
-0
> Math.ceil(-0.0, 1)
-0
> Math.ceil(-0.01, 1)
-0>>> round(-0.0, 0)
-0.0
>>> round(-0.0, 1)
-0.0
>>> round(-0.01, 1)
-0.0
>>> round(-0.01, 0)
-0.0
Member
There was a problem hiding this comment.
Looks excellent to me, awesome summary and proposal.
sabiwara
force-pushed
the
otp27-fixes
branch
from
11e03cd to
5edfdd6
Compare
sabiwara
commented
Feb 16, 2024
| iex> {:ok, _} = Registry.register(Registry.SelectAllTest, "world", :value) | ||
| iex> Registry.select(Registry.SelectAllTest, [{{:"$1", :"$2", :"$3"}, [], [{{:"$1", :"$2", :"$3"}}]}]) | ||
| [{"world", self(), :value}, {"hello", self(), :value}] | ||
| iex> Registry.select(Registry.SelectAllTest, [{{:"$1", :"$2", :"$3"}, [], [{{:"$1", :"$2", :"$3"}}]}]) |> Enum.sort() |
Contributor
Author
josevalim
approved these changes
Feb 16, 2024
josevalim
pushed a commit
that referenced
this pull request
Feb 24, 2024
* Fix non-deterministic key-value tests * Fix non-deterministic Enum tests * Fix :only option when deriving Inspect * Float.ceil and Float.floor return -0.0 for negative numbers * Fix non-deterministic Registry doctest * Simplify check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes most of the small breakage in the CI due to the
-0.0change and non-deterministic order of keys.There is still a breaking test for
Registry, and I haven't looked intoIEx/mixetc yet, will look into it later.