Fix unexpected rounding signs on OPT26- #13365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabiwara
commented
Feb 23, 2024
|
|
||
| # TODO remove and replace by assert once we require Erlang/OTP 27+ | ||
| # We can't easily distinguish between -0.0 and +0.0 on previous version | ||
| defmacrop float_assert({:===, _, [left, right]}) do |
Contributor
Author
There was a problem hiding this comment.
I went with this approach because it gives us:
- useful assertions
- useful error messages on failure
- can easily be removed since it is not here to stay
sabiwara
commented
Feb 23, 2024
sabiwara
force-pushed
the
float_round_zero
branch
from
e98ca80 to
e7d3de0
Compare
josevalim
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditionals returning
-0.0or0.0were triggering this bug: erlang/otp#7168.We can trick the compiler to avoid this optimization through an extra private function.