adds test_pid field in the test metadata #13880
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
requested changes
Oct 6, 2024
whatyouhide
reviewed
Oct 6, 2024
Co-authored-by: Andrea Leopardi <an.leopardi@gmail.com>
|
@ityonemo ping in case it fell through the cracks. :) |
|
@ityonemo I've added a test case at ityonemo#1 I'd love for this to go through so I can use it to print out richer information about sandbox/allowance failures from a custom ex_unit formatter! |
|
Thank you @axelson! Looking at the test you added, I think it would be much simpler to test_pid at the beginning, simpler to use and to test too, so I pushed this change. Thank you both! |
|
Nice! Thank you José! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this enhancement adds a
test_pidfield into the test context metadata. This is useful for backtracking which test is responsible when a ecto sandbox or mox allowance has triggered after the parent test has finished. For now, one will have to write a customExUnit.Formatterto take advantage of this extra metadata.