Skip to content

Parallel compiler emits more profile info #13941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Parallel compiler emits more profile info #13941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 25 additions & 14 deletions lib/elixir/lib/kernel/parallel_compiler.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ defmodule Kernel.ParallelCompiler do
end)

[] = files
cycle_return = each_cycle_return(state.each_cycle.())
cycle_return = measure_timing(state, "each_cycle callback", fn -> each_cycle_return(state.each_cycle.()) end)
state = cycle_timing(result, state)

case cycle_return do
Expand Down Expand Up @@ -519,21 +519,23 @@ defmodule Kernel.ParallelCompiler do
# Finally, note there is no difference between hard and raise, the
# difference is where the raise is happening, inside the compiler
# or in the caller.
waiting_list = Map.to_list(waiting)
measure_timing(state, "spawn_workers/8 in potential deadlock situation", fn ->
waiting_list = Map.to_list(waiting)

deadlocked =
deadlocked(waiting_list, :soft, false) ||
deadlocked(waiting_list, :soft, true) ||
deadlocked(waiting_list, :hard, false) ||
without_definition(waiting_list, files)
deadlocked =
deadlocked(waiting_list, :soft, false) ||
deadlocked(waiting_list, :soft, true) ||
deadlocked(waiting_list, :hard, false) ||
without_definition(waiting_list, files)

if deadlocked do
spawn_workers(deadlocked, spawned, waiting, files, result, warnings, errors, state)
else
return_error(warnings, errors, state, fn ->
handle_deadlock(waiting, files)
end)
end
if deadlocked do
spawn_workers(deadlocked, spawned, waiting, files, result, warnings, errors, state)
else
return_error(warnings, errors, state, fn ->
handle_deadlock(waiting, files)
end)
end
end)
end

# No more queue, but spawned and map_size(waiting) do not match
Expand All @@ -558,6 +560,15 @@ defmodule Kernel.ParallelCompiler do
end
end

defp measure_timing(%{profile: :none}, _what, fun), do: fun.()
defp measure_timing(%{profile: {:time, _, _}}, what, fun) do
{time, result} = :timer.tc(fun)
time = div(time, 1000)

IO.puts(:stderr, "[profile] Executed #{what} in #{time}ms")
result
end

defp cycle_timing(_result, %{profile: :none} = state) do
state
end
Expand Down