Tweak NaiveDateTime.from_erl and Time.from_erl specs

[elfenlaid]

The changes align NaiveDateTime.from_erl and Time.from_erl specs with their corresponding NaiveDateTime.new and Time.new specs.

The new function specs accept a non-negative integer or a tuple of {seconds, precision} for microseconds.

Here's NaiveDateTime.new/8's spec:

elixir/lib/elixir/lib/calendar/naive_datetime.ex

Lines 248 to 257 in cb2e036

	@spec new(
	Calendar.year(),
	Calendar.month(),
	Calendar.day(),
	Calendar.hour(),
	Calendar.minute(),
	Calendar.second(),
	Calendar.microsecond() | non_neg_integer,
	Calendar.calendar()
	) :: {:ok, t} | {:error, atom}

And NaiveDateTime.from_erl's spec + implementation:

elixir/lib/elixir/lib/calendar/naive_datetime.ex

Lines 1004 to 1011 in cb2e036

	@spec from_erl(:calendar.datetime(), Calendar.microsecond(), Calendar.calendar()) ::
	{:ok, t} | {:error, atom}
	def from_erl(tuple, microsecond \\ {0, 0}, calendar \\ Calendar.ISO)
	def from_erl({{year, month, day}, {hour, minute, second}}, microsecond, calendar) do
	with {:ok, iso_naive_dt} <- new(year, month, day, hour, minute, second, microsecond),
	do: convert(iso_naive_dt, calendar)
	end

Here's the Time.new/5 spec:

elixir/lib/elixir/lib/calendar/time.ex

Lines 114 to 120 in cb2e036

	@spec new(
	Calendar.hour(),
	Calendar.minute(),
	Calendar.second(),
	Calendar.microsecond() | non_neg_integer,
	Calendar.calendar()
	) :: {:ok, t} | {:error, atom}

And the corresponding from_erl:

elixir/lib/elixir/lib/calendar/time.ex

Lines 364 to 371 in cb2e036

	@spec from_erl(:calendar.time(), Calendar.microsecond(), Calendar.calendar()) ::
	{:ok, t} | {:error, atom}
	def from_erl(tuple, microsecond \\ {0, 0}, calendar \\ Calendar.ISO)
	def from_erl({hour, minute, second}, microsecond, calendar) do
	with {:ok, time} <- new(hour, minute, second, microsecond, Calendar.ISO),
	do: convert(time, calendar)
	end

In both cases, the corresponding new functions handle non_negative_integer microseconds. I also added tests to confirm it.

---

Please notice that both NaiveDateTime.t.microsecond and Time.t.microsecond are of Calendar.microsecond() type, and it's okay because new functions set microsecond: {microsecond, 6} with default precision if none is provided.

[elfenlaid]

I'm not sure here, but the rest of the file uses non_neg_integer() spec notation, so I tweaked the spec here.

[elfenlaid]

I'm not sure here, but the rest of the file uses non_neg_integer() spec notation, so I tweaked the spec here.

[elfenlaid]

I'm not sure here, but the rest of the file uses non_neg_integer() spec notation, so I tweaked the spec here.

[elfenlaid]

The docs were lacking the basic from_erl case, from_erl! has it, so I added one here too.

[josevalim]

💚 💙 💜 💛 ❤️