Improve perf of tuple operations #13988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Nov 12, 2024
|
|
||
| defp tuple_union(left, right), do: left ++ right | ||
| # Removes duplicates in union, which should trickle to other operations. | ||
| defp tuple_union(left, right), do: left ++ (right -- left) |
There was a problem hiding this comment.
This is performing structural equality. Should we add a TODO saying this is a cheap optimization?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pruning to tuple_difference and tuple_union. This eliminates obviously empty negations
(such as
{integer(), atom()} and not {atom(), ...}) from the representation, which drastically reduces its size in corner cases like the example added.