Skip to content

kwlist are inspected as a list of tuples with raw: true #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Jul 12, 2013
Merged

kwlist are inspected as a list of tuples with raw: true #1419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/elixir/lib/inspect.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ defimpl Inspect, for: List do
cond do
:io_lib.printable_list(thing) ->
<< ?', String.escape(:unicode.characters_to_binary(thing), ?') :: binary, ?' >>
keyword?(thing) ->
keyword?(thing) && !opts.raw ->
surround_many("[", thing, "]", opts.limit, keyword(&1, opts))
true ->
surround_many("[", thing, "]", opts.limit, Kernel.inspect(&1, opts))
Expand Down
6 changes: 6 additions & 0 deletions lib/elixir/test/elixir/inspect_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,12 @@ defmodule Inspect.ListTest do
"[foo: [1, 2, 3, :bar],\n bazzz: :bat]"
end

test :keyword_with_raw do
assert inspect([a: 1], raw: true) == "[{:a, 1}]"
assert inspect([a: 1, b: 2], raw: true) == "[{:a, 1}, {:b, 2}]"
assert inspect([a: 1, a: 2, b: 2], raw: true) == "[{:a, 1}, {:a, 2}, {:b, 2}]"
end

test :non_keyword do
assert inspect([{ Regex, 1 }]) == "[{Regex, 1}]"
end
Expand Down