Skip to content

Fix how UTF8 env is stored in .app file #14890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
+3 −3
Merged

Fix how UTF8 env is stored in .app file #14890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/mix/lib/mix/tasks/compile.app.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ defmodule Mix.Tasks.Compile.App do
:application.load({:application, app, properties})

Mix.Project.ensure_structure()
File.write!(target, [contents, ?.])
File.write!(target, IO.chardata_to_string([contents, ?.]))
File.touch!(target, new_mtime)

# If we just created the .app file, it will have touched
Expand Down
4 changes: 2 additions & 2 deletions lib/mix/test/mix/tasks/compile.app_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ defmodule Mix.Tasks.Compile.AppTest do
test "uses custom application settings" do
in_fixture("no_mixfile", fn ->
Mix.Project.push(CustomProject)
env = [foo: [:one, "two", 3, 4], bar: [{} | %{foo: :bar}]]
env = [foo: [:one, "two", 3, 4, "฿"], bar: [{} | %{foo: :bar}]]

Process.put(:application,
maxT: :infinity,
Expand All @@ -132,7 +132,7 @@ defmodule Mix.Tasks.Compile.AppTest do
assert properties[:applications] ==
[:kernel, :stdlib, :elixir, :logger, :ex_unit, :example_app, :mix]

assert properties[:env] == [foo: [:one, "two", 3, 4], bar: [{} | %{foo: :bar}]]
assert properties[:env] == [foo: [:one, "two", 3, 4, "฿"], bar: [{} | %{foo: :bar}]]

refute Keyword.has_key?(properties, :extra_applications)
end)
Expand Down