Tighten up Markdownlint rule: Trailing punctuation in heading #14966
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eksperimental
force-pushed
the
chore/markdown-tighten-up2
branch
from
89f5bee to
1ecfdf4
Compare
eksperimental
changed the title
eksperimental
changed the title
eksperimental
force-pushed
the
chore/markdown-tighten-up2
branch
from
1ecfdf4 to
033c1aa
Compare
whatyouhide
approved these changes
Nov 28, 2025
josevalim
reviewed
Nov 28, 2025
Member
|
Fwiw, there are also conflicts (but I can't resolve them because there is no permission for us to push to the PR branch). |
Rule MD026 "Trailing punctuation in heading" is enforced, we simply remove `!` from the list of forbidden characters. Source: https://github.com/DavidAnson/markdownlint/blob/main/doc/md026.md
eksperimental
force-pushed
the
chore/markdown-tighten-up2
branch
from
6c636a6 to
009fc43
Compare
Contributor
Author
|
Conflicts resolved.
Is there a way I can permanently enable certain people to edit PRs in my repo? |
Member
I don't know :( I know you can enable per PR and for me the option is usually checked by default. |
Member
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rule MD026 "Trailing punctuation in heading" is enforced, we simply remove
!from the list of forbidden characters.Source: https://github.com/DavidAnson/markdownlint/blob/main/doc/md026.md