Skip to content

Conversation

@eksperimental
Copy link
Contributor

@eksperimental eksperimental commented Nov 28, 2025

This file was originally created on 2020-06-26,
therefore the copyright belonged to Plataformatec at the time.

Copy link
Member

@maennchen maennchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tool i built to add the headers checked if a file is completely different since then and no longer adds old copyright. This is so different that the old copyright no longer applies: https://github.com/elixir-lang/elixir/blob/b059d5ad37fe412ef151935d4765f0cb5b12c7df/.github/workflows/ci.yml

This file was originally created on 2020-06-26,
therefore the copyright belong to Plataformatec at the time.
@eksperimental eksperimental force-pushed the chore/ci-update-spdx-copyright branch from a73aa71 to 5822de3 Compare November 28, 2025 00:07
@maennchen
Copy link
Member

Just for background: The Copyright header states who has copyright on this file content right now, not who held it at some point in the past.

If you for example completely re-implement a module without looking at the old code, you could remove the old header.

@eksperimental
Copy link
Contributor Author

eksperimental commented Nov 28, 2025

This is the original PR: #10129

I don't know how your tool calculates the difference, but it is certainly the same file structure, with more content now.

@maennchen
Copy link
Member

@eksperimental Oh sorry, I did not look at the full file right now. You are correct.

I'll see what happened tomorrow. That might affect more files.

@josevalim josevalim merged commit 68ebb78 into elixir-lang:main Nov 28, 2025
13 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@eksperimental eksperimental deleted the chore/ci-update-spdx-copyright branch November 28, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants