Skip to content

Fix dialyzer warnings on EEx.eval_string #14971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Nov 29, 2025
Merged

Fix dialyzer warnings on EEx.eval_string #14971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/eex/lib/eex.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,7 @@ defmodule EEx do
### Helpers

defp do_eval(compiled, bindings, options) do
options = Keyword.take(options, [:file, :line, :module, :prune_binding])
{result, _} = Code.eval_quoted(compiled, bindings, options)
result
end
Expand Down
4 changes: 4 additions & 0 deletions lib/elixir/test/elixir/fixtures/dialyzer/regressions.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,8 @@ defmodule Dialyzer.Regressions do
migrate: true
)
end

def eex_eval_opts do
EEx.eval_string("foo <%= bar %>", [bar: "baz"], trim: true)
end
end
1 change: 1 addition & 0 deletions lib/elixir/test/elixir/kernel/dialyzer_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ defmodule Kernel.DialyzerTest do
ArgumentError,
Atom,
Code,
EEx,
Enum,
Exception,
ExUnit.AssertionError,
Expand Down