Skip to content

fix: fixes terminating Task report_cb formatted message #14975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2025
+4 −4
Merged

fix: fixes terminating Task report_cb formatted message #14975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/elixir/lib/task/supervised.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ defmodule Task.Supervised do
~c"** When function == ~p~n" ++
~c"** arguments == ~p~n" ++ ~c"** Reason for termination == ~n" ++ ~c"** ~p~n"

terms = [name, fun, args, get_reason(reason)]
terms = [starter, fun, args, get_reason(reason)]

{message, terms} =
case process_label do
Expand All @@ -173,7 +173,7 @@ defmodule Task.Supervised do
message =
~c"** Task ~p terminating~n" ++ message

{message, [starter | terms]}
{message, [name | terms]}
end

defp get_from({node, pid_or_name, _pid}) when node == node(), do: pid_or_name
Expand Down
4 changes: 2 additions & 2 deletions lib/elixir/test/elixir/task_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1130,8 +1130,8 @@ defmodule TaskTest do
send(pid, :go)
receive do: ({:DOWN, ^ref, _, _, _} -> :ok)
end) =~ ~r"""
\[error\] \*\* Task #PID<\d+\.\d+\.\d+> terminating
\*\* Started from #PID<\d+\.\d+\.\d+>
\[error\] \*\* Task #{inspect(pid)} terminating
\*\* Started from #{inspect(parent)}
\*\* When function == &TaskTest.task/1
\*\* arguments == \[#PID<\d+\.\d+\.\d+>\]
\*\* Reason for termination ==\s
Expand Down