Add type inference for literal equality in guards#15041
Merged
Conversation
Member
Author
|
💚 💙 💜 💛 ❤️ |
vanderhoop
reviewed
Jan 9, 2026
Comment on lines
+3994
to
+3999
| bdd | ||
| |> map_bdd_to_dnf() | ||
| |> Enum.map(fn {tag, fields, negs} -> | ||
| map_eliminate_while_negs_decrease(tag, fields, negs) | ||
| end) | ||
| |> map_fusion() |
Contributor
There was a problem hiding this comment.
Inner monologue: "Can this module leverage streams more often?"
Member
Author
There was a problem hiding this comment.
Streams are often more expensive because they abstract over lazy collections. They are meant to deal with large collections, which is not the case here. If we want performance, then we should fold Enum operations, not use streams (i.e. don't do map |> map |> filter, do a single one, or use flat_map/reduce). We do all of these things already.
Contributor
There was a problem hiding this comment.
dig; make sense! thanks for the explanation!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.