Fix File.Stream Enumerable.count for files without trailing newline#15147
Merged
josevalim merged 1 commit intoelixir-lang:mainfrom Mar 7, 2026
Merged
Conversation
The optimized count implementation was counting newline characters instead of actual lines, returning incorrect results for files that don't end with a newline (which is common for source code files). For example, a file with content "line1\nline2\nline3" (3 lines) was returning 2 instead of 3. The fix tracks the last byte read and adds 1 at EOF if the file has content but doesn't end with a newline.
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The optimized count implementation was counting newline characters instead of actual lines, returning incorrect results for files that don't end with a newline (which is common for source code files).
For example, a file with content "line1\nline2\nline3" (3 lines) was returning 2 instead of 3.
The fix tracks the last byte read and adds 1 at EOF if the file has content but doesn't end with a newline.
You can reproduce it with: