Add :dbg_callback option to Code eval functions#15189
Merged
josevalim merged 1 commit intoelixir-lang:mainfrom Mar 13, 2026
Merged
Add :dbg_callback option to Code eval functions#15189josevalim merged 1 commit intoelixir-lang:mainfrom
josevalim merged 1 commit intoelixir-lang:mainfrom
Conversation
jonatanklosko
commented
Mar 13, 2026
| """ | ||
| @spec eval_string(List.Chars.t(), binding, Macro.Env.t() | env_eval_opts) :: {term, binding} | ||
| def eval_string(string, binding \\ [], opts \\ []) | ||
| @spec eval_string(List.Chars.t(), binding, Macro.Env.t() | [eval_opt | env_eval_opt]) :: |
Member
Author
There was a problem hiding this comment.
Note that it's not possible to pass %Macro.Env{} and eval option such as :prune_binding, but that's an inherent limitation of the current API. We could add opts \\ [] as another argument, but having three arguments with default values is likely too much.
It's not necessarily an issue though, because Code.eval_quoted_with_env/4 already provides more control by having separate env and opts options.
jonatanklosko
force-pushed
the
jk-eval-dbg-callback
branch
2 times, most recently
from
c5fb074 to
ec19505
Compare
jonatanklosko
force-pushed
the
jk-eval-dbg-callback
branch
from
ec19505 to
10be0e6
Compare
jonatanklosko
commented
Mar 13, 2026
| assert Macro.Env.vars(env) == [] | ||
| end | ||
|
|
||
| test "with :dbg_callback" do |
Member
Author
There was a problem hiding this comment.
Perhaps a single test for :dbg_callback is enough, since I added a test for :prune_binding to all of the functions to make sure the operations are propagated. Let me know if you have a preference!
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
:dbg_callbackoption toCode.eval_*functions, which overrides thedbg/2behaviour specifically for the evaluation.The
dbgcallback is a compile time config. When doing dynamic evaluation, it may be desirable to override thedbgbehaviour. WhileApplication.put_env(:elixir, :dbg_callback, ...)works, overriding application compile env at runtime shouldn't be done and this approach leads to issues (for example #15178). By having:dbg_callbackon the eval functions, we effectively configure the compilation of that dynamic code, without changes to the application environment.This also fixes a bug where
:prune_bindingwas documented not supported byeval_string/3andeval_quoted/3.