Optimize Keyword.validate/2 to avoid building new list#15269
Merged
sabiwara merged 1 commit intoelixir-lang:mainfrom Apr 14, 2026
Merged
Optimize Keyword.validate/2 to avoid building new list#15269sabiwara merged 1 commit intoelixir-lang:mainfrom
sabiwara merged 1 commit intoelixir-lang:mainfrom
Conversation
josevalim
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe I'm missing something, but as far as I can tell, there is no need to re-build that kw-list, since in the case there is a "bad_key" we're not using the acc anyway?
So we just end up reversing the list for no reason - this new version just returns the original as is, which is less work:
Confirmed with a quick benchmark that this reduces the memory footprint: