Keep empty strings when splitting #1645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To stay consistent with both `String.split/2` and `:binary.split` we need to keep around empty strings that are accumulated while splitting. In the future we could support the `:trim` option to consistently remove these in call calls to `String.split`. Fixes elixir-lang#1636
josevalim
pushed a commit
that referenced
this pull request
Aug 24, 2013
Keep empty strings when splitting
Member
|
Thanks @vanstee. Could you also please send a pull request that adds |
Contributor
Author
|
Sure. Should it also remove empty strings from the middle? Should we make |
Member
Member
|
I'm hesitant to trimming by default. Are any other languages trimming by default? If we trim I think we should trim the middle as well. |
Contributor
|
@ericmj Ruby does. |
Member
|
Looks like Python trims by default as well. Haskell and .NET does not. Consistent among all default trimmers is that they trim the middle as well. |
Member
|
Ok, let's trim by default and trim in the middle too! |
Contributor
Author
|
Sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To stay consistent with both
String.split/2and:binary.splitweneed to keep around empty strings that are accumulated while splitting.
In the future we could support the
:trimoption to consistently removethese in call calls to
String.split.Fixes #1636