Allow Macro.escape([1|2]) #1648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/elixir/src/elixir_quote.erl
Outdated
Member
There was a problem hiding this comment.
Can we just apply this change if Q#elixir_quote.escape is true?
Member
There was a problem hiding this comment.
I am wondering, maybe instead of reverse_improper returning two different results, could it simply the list with { '|', [], [left, right] } which we then simply pass to do_splice? Thanks!
Author
There was a problem hiding this comment.
That was my first attempt. But do_splice would quote that and you can't force it to unquote because the unquote option might not be on.
This fixes elixir-lang#1646
Author
|
Updated to only make the new code trigger when escape is used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1646
I'm not 100% happy with this change, it adds one list traversal in the common case and another in the uncommon case (improper list). However I couldn't see a better way. I suspect a more elegant solution would involve rewriting do_splice to not use a reversed list as input.