underlines within links have to be escaped #1829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in links the underline will be escaped with the ansi escape sequence code `4` (underline). To avoid this behavior it have to be properly escaped.
Member
|
Good job! Much better than the solution I had in mind! :D |
josevalim
pushed a commit
that referenced
this pull request
Oct 30, 2013
…sidoc underlines within links have to be escaped
Member
|
❤️ 💚 💙 💛 💜 |
Contributor
Author
|
Thank you! But it was a process, at first it was more a try hard thing. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@josevalim That's a first attempt to fix the issue.
In links the underline will be escaped with the ansi escape sequence code
4(underline).To avoid this behavior it have to be properly escaped.
cheers
PS: I couldn't add the pull-request to the already open issue, so I had to make a separat PR. #1811