Elixirc: fail when one of the provided file pattern is missing #1933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
pushed a commit
that referenced
this pull request
Dec 31, 2013
Elixirc: fail when one of the provided file pattern is missing
Member
|
Merged, thank you! ❤️ 💚 💙 💛 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous logic didn't allow for a simple fix (patterns were converted all at once and then everything was concatened, thus squashing all the empty lists == missing files).
In this PR, I am proposing to solve the issue #1923 by going through the list of patterns and collect all the patterns that returned no files. If there was at least one, then the process_command for :compile will return an error with a similar error message as before, except that now it's a bit more descriptive (only the missing patterns are mentioned).
It wouldn't be very difficult to change the code to proceed with the compilation despite the missing files and just issue a warning, but it's probably more sane to just fail right away.