Make it clearer that unimplemented callbacks always stop #3723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
ergh, :noreply here, that is confusing
Member
|
Maybe this is bike shedding but in |
lexmag
force-pushed
the
dialyzer-trick
branch
from
229afc5 to
5e5d2d4
Compare
lexmag
force-pushed
the
dialyzer-trick
branch
from
5e5d2d4 to
55c002e
Compare
fishcakez
added a commit
that referenced
this pull request
Sep 11, 2015
Make it clearer that unimplemented callbacks always stop
Member
|
Thank you! |
Member
Author
|
Glad to help. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\cc @fishcakez