Fix bug in Path.join. Fix #4252.

[danhper]

This should fix #4252.

[josevalim]

I am not very confident with this byte_size call. Maybe we could fix this by moving remove_dirsep inside the do_join calls below and only call it when appropriate? Can you give this alternative solution a try to see if things are better or worse? Thank you!

[danhper]

Sure, I'll give it a try!

[josevalim]

Thank you! I have added a comment!

[danhper]

@josevalim I tried to move the logic to do_join but I am not sure if there is
a way to avoid checking the byte size, as the / case is a little special.

Maybe it would be better to move the last remove_dirsep call in a normalize
function or something like this and handle this logic there.

[lexmag]

Why do we need "" inside the pattern?
<<_, "">> is the same as <<_>>.

[danhper]

Thank you, I changed the code a little!

[josevalim]

Maybe we can change remove_dirsep to not do anything if it receives only
"/" then?

On Tuesday, February 2, 2016, Daniel Perez notifications@github.com wrote:

@josevalim https://github.com/josevalim I tried to move the logic to
do_join but I am not sure if there is
a way to avoid checking the byte size, as the / case is a little special.

Maybe it would be better to move the last remove_dirsep call in a
normalize
function or something like this and handle this logic there.

—
Reply to this email directly or view it on GitHub
#4253 (comment).

José Valimwww.plataformatec.com.br
http://www.plataformatec.com.br/Founder and Director of R&D

[josevalim]

@tuvistavie I have added a new comment so maybe we explicitly check for "/" in remove_dirsep. That should achieve the same but a bit more cleanly? Thanks for trying all of those different approaches!

[danhper]

@josevalim Sorry for the delay.

I changed the remove_dirsep and do_join
to make this a little cleaner. This should work prefectly for UNIX/Linux based OS,
but I am not very sure if we need to do something special for Windows here.