Fix nfd normalization bug #4606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| @spec normalize(t, atom) :: boolean | ||
| @spec normalize(t, atom) :: t |
Contributor
Author
There was a problem hiding this comment.
💁 Don't know if this is the right place to change this but it seems incorrect.
Member
|
❤️ 💚 💙 💛 💜 |
josevalim
pushed a commit
that referenced
this pull request
May 16, 2016
* Fix nfd normalization bug * Change String.normalize return type to binary Signed-off-by: José Valim <jose.valim@plataformatec.com.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4604.
💁 No new tests were added, only reverted the two failing specs from this commit: 107a185