Ensure paths stored in manifest are relative

[ericmj]

No description provided.

[josevalim]

We should probably do this when we build the records and not as a post
processing step later on.

On Friday, June 3, 2016, Eric Meadows-Jönsson notifications@github.com
wrote:

---

You can view, comment on, or merge this pull request online at:

#4767
Commit Summary

• Ensure paths stored in manifest are relative

File Changes

• M lib/mix/lib/mix/compilers/elixir.ex
  https://github.com/elixir-lang/elixir/pull/4767/files#diff-0 (12)

Patch Links:

• https://github.com/elixir-lang/elixir/pull/4767.patch
• https://github.com/elixir-lang/elixir/pull/4767.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#4767, or mute the thread
https://github.com/notifications/unsubscribe/AAAlbsM8_xjVgDsJ7NwYKikCgpV8fH2jks5qH_xUgaJpZM4ItYo6
.

José Valim
www.plataformatec.com.br
Skype: jv.ptec
Founder and Director of R&D

[ericmj]

@josevalim We already seem to do that (in 1.2.5 also). But that raises the question where the absolute paths are coming from.

[josevalim]

@ericmj so we should likely answer that question before merging this. :)

[ericmj]

Found the root cause; for dependencies the relative path does not work since _build/ is relative from the project directory - not from deps/my_dep.

The fix is to only store the filename in the manifest and build the absolute path when reading the manifest file.

[josevalim]

There is a TODO!

[josevalim]

That you didn't do!

[ericmj]

Oops, that's embarrassing.

[ericmj]

Pushed with fixes based on your comments.

[josevalim]