Clarify Enum.group_by/3 deprecation message #4852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/elixir/lib/enum.ex
Outdated
Member
There was a problem hiding this comment.
Great catch! Can you please add a space after the dot on this line? Thank you!
Member
|
@mgartner I have added two comments and we should be good to go! |
Contributor
Author
|
@josevalim updated! |
josevalim
pushed a commit
that referenced
this pull request
Jun 22, 2016
Signed-off-by: José Valim <jose.valim@plataformatec.com.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading one of my projects to Elixir v1.3, I found the
Enum.group_by/3deprecation message to be a bit confusing. It says toplease use a map instead, but a map is used by default with the new form ofEnum.group_by/3. The user only needs to remove the map as an argument to the function.I think this makes it a little more clear what do to. I'm open to any suggestions here.