Generate error for no pid given to Genserver.reply #4876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change it is possible to send any two-pair tuple to `GenServer.reply/2` and it will happily reply with `:ok`. This leads to some hard to track-down bugs if you pass it the wrong data. With this small check developers may be able to get a bit more of a heads up to what is going wrong sooner. For more information on how I came accross this: benfalk/data_pool@dcf81d1
Member
|
@fishcakez it is all yours. |
Member
|
Thank you ❤️ |
josevalim
pushed a commit
that referenced
this pull request
Jun 24, 2016
Prior to this change it is possible to send any two-pair tuple to `GenServer.reply/2` and it will happily return `:ok`, catching any errors. This leads to some hard to track-down bugs if you pass it the wrong term. Signed-off-by: José Valim <jose.valim@plataformatec.com.br>
eksperimental
added a commit
to eksperimental-forks/elixir
that referenced
this pull request
Jun 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change it is possible to send any two-pair tuple to
GenServer.reply/2and it will happily reply with:ok. Thisleads to some hard to track-down bugs if you pass it the wrong
data. With this small check developers may be able to get a bit
more of a heads up to what is going wrong sooner.
For more information on how I came accross this:
benfalk/data_pool@dcf81d1