Revert mix do to enforce space after comma #4893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/mix/lib/mix/tasks/do.ex
Outdated
Member
There was a problem hiding this comment.
Since we're changing this, I think better to replace one-letter variable with name from previous implementation.
Author
There was a problem hiding this comment.
Thanks for the feedback, I just updated the PR.
lib/mix/test/mix/tasks/do_test.exs
Outdated
Member
There was a problem hiding this comment.
I think we should keep the tests but adjust them accordingly. I think it may reveal cases we can handle, like this one.
Author
There was a problem hiding this comment.
I just restored the tests and added one for the regression that was reported.
Member
|
❤️ 💚 💙 💛 💜 |
josevalim
pushed a commit
that referenced
this pull request
Jun 27, 2016
Signed-off-by: José Valim <jose.valim@plataformatec.com.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reverted the
mix dobehavior, this should fix #4861.Sorry for messing up! 😓