Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions lib/elixir/lib/code.ex
Original file line number Diff line number Diff line change
Expand Up @@ -440,9 +440,16 @@ defmodule Code do
def compiler_options(opts) do
available = available_compiler_options()

for {k, _} <- opts,
not k in available,
do: raise "unknown compiler options: #{k}"
Enum.each(opts, fn({key, value}) ->
cond do
not key in available ->
raise "unknown compiler option: #{inspect(key)}"
not is_boolean(value) ->
raise "compiler option #{inspect(key)} should be a boolean, got: #{inspect(value)}"
true ->
:ok
end
end)

:elixir_config.update :compiler_options, &Enum.into(opts, &1)
end
Expand Down
12 changes: 12 additions & 0 deletions lib/elixir/test/elixir/code_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,18 @@ defmodule CodeTest do
assert Code.ensure_compiled?(__MODULE__)
refute Code.ensure_compiled?(Code.NoFile)
end

test "compiler_options/1 validates options" do
message = "unknown compiler option: :not_a_valid_option"
assert_raise RuntimeError, message, fn ->
Code.compiler_options(not_a_valid_option: :foo)
end

message = "compiler option :debug_info should be a boolean, got: :not_a_boolean"
assert_raise RuntimeError, message, fn ->
Code.compiler_options(debug_info: :not_a_boolean)
end
end
end

defmodule Code.SyncTest do
Expand Down