Fixed codestyle for OptionParser tests #5714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I am personally ok with this change, but others may feel like this is too many changes and maybe not worth it. I will not formally approve the changes but count me as 👍 :) |
Contributor
Author
|
I have the same feeling, but lets see 😄 |
josevalim
approved these changes
Jan 28, 2017
Contributor
Author
|
There are some weird test fluctuations today.. |
Member
|
Thank you @AndrewDryga! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #5709 @whatyouhide mentioned that this tests are violating new style guide, this PR should fix it.