Validate the value of the @on_load attribute#6038
Merged
Merged
Conversation
josevalim
reviewed
Apr 27, 2017
|
|
||
| defp preprocess_attribute(:on_load, atom) when is_atom(atom) do | ||
| {atom, 0} | ||
| defp preprocess_attribute(:on_load, value) do |
Member
There was a problem hiding this comment.
The @on_load attribute can be either {:fun, 0} or :fun. So I think we should probably leave this clause intact and add a clause that check when it is not in the tuple format above.
Member
Author
There was a problem hiding this comment.
Oh missed that, that's right. We don't document it in the docs for Module though, should we?
Member
Author
There was a problem hiding this comment.
Got it, updated. I didn't follow your suggestion but went with a single clause where we validate the value, similar to what we do for other attributes. Let me know if you prefer your suggestion and I'll change it :)
josevalim
approved these changes
Apr 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this could be a way to implement this check:
from #5800. Thoughts?