Remove any use of Regex in the Version.Parser module #6077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
May 8, 2017
lib/elixir/lib/version.ex
Outdated
| :error | ||
| end | ||
| end | ||
| destructure [version_with_pre, build_metadata], String.split(string, "+", parts: 2) |
Member
There was a problem hiding this comment.
Why not?
[version_with_pre | build_metadata] = String.split(string, "+")
Member
Author
There was a problem hiding this comment.
Only one + is allowed. I don't see the advantage of doing that :|
Member
|
❤️ 💚 💙 💛 💜 |
josevalim
pushed a commit
that referenced
this pull request
May 8, 2017
Signed-off-by: José Valim <jose.valim@plataformatec.com.br>
ericmj
reviewed
May 8, 2017
| end | ||
| destructure [version_with_pre, build], String.split(string, "+", parts: 2) | ||
| destructure [version, pre], String.split(version_with_pre, "-", parts: 2) | ||
| destructure [major, minor, patch], String.split(version, ".") |
Member
There was a problem hiding this comment.
Do we have a test case for "1.2.3.4"? I don't see how we catch this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.