Properly escape fields passed to defrecord #6086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
May 9, 2017
Member
There was a problem hiding this comment.
Maybe a comment here saying that we need to have this on its own line to detect any escaping issues which would be by passed with we just passed it to the macro below?
Member
There was a problem hiding this comment.
Or maybe have two tests. One for defaults/0 and another for defaults/1.
Member
Author
There was a problem hiding this comment.
Both suggestions make sense 👍
ericmj
approved these changes
May 9, 2017
Member
Author
|
Backported to 1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #6060.