Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/elixir/lib/enum.ex
Original file line number Diff line number Diff line change
Expand Up @@ -2710,10 +2710,10 @@ defmodule Enum do
end

@doc """
Zips corresponding elements from a collection of enumerables
Zips corresponding elements from a list of enumerables
into one list of tuples.

The zipping finishes as soon as any enumerable completes.
The zipping finishes as soon as any enumerable in the given list completes.

## Examples

Expand All @@ -2728,7 +2728,7 @@ defmodule Enum do

def zip([]), do: []

def zip(enumerables) do
def zip(enumerables) when is_list(enumerables) do
Stream.zip(enumerables).({:cont, []}, &{:cont, [&1 | &2]})
|> elem(1)
|> :lists.reverse
Expand Down
9 changes: 5 additions & 4 deletions lib/elixir/lib/stream.ex
Original file line number Diff line number Diff line change
Expand Up @@ -1033,10 +1033,10 @@ defmodule Stream do
def zip(left, right), do: zip([left, right])

@doc """
Zips corresponding elements from a collection of enumerables
Zips corresponding elements from a list of enumerables
into one stream of tuples.

The zipping finishes as soon as any enumerable completes.
The zipping finishes as soon as any enumerable in the given list completes.

## Examples

Expand All @@ -1047,8 +1047,9 @@ defmodule Stream do

"""
@spec zip([Enumerable.t]) :: Enumerable.t
def zip(enumerables) do
step = &do_zip_step(&1, &2)
def zip(enumerables) when is_list(enumerables) do
step = &do_zip_step(&1, &2)

enum_funs = Enum.map(enumerables, fn enum ->
{&Enumerable.reduce(enum, &1, step), :cont}
end)
Expand Down
6 changes: 5 additions & 1 deletion lib/elixir/test/elixir/enum_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -812,7 +812,11 @@ defmodule EnumTest do
assert Enum.zip([[]]) == []
assert Enum.zip([[1]]) == [{1}]

assert Enum.zip([[], [], [], []]) == []
assert Enum.zip([[], [], [], []]) == []

assert_raise FunctionClauseError, fn ->
Enum.zip(%{})
end
end
end

Expand Down
5 changes: 5 additions & 0 deletions lib/elixir/test/elixir/stream_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -1007,6 +1007,11 @@ test "transform/4 closes on nested errors" do
cycle = Stream.cycle([:a, :b, :c])
assert Stream.zip([concat, cycle]) |> Enum.to_list ==
[{1, :a}, {2, :b}, {3, :c}, {4, :a}, {5, :b}, {6, :c}]

assert_raise FunctionClauseError, fn ->
enum_of_enums = Stream.cycle([[1, 2], [:a, :b]])
Stream.zip(enum_of_enums)
end
end

test "zip/1 does not leave streams suspended" do
Expand Down