Skip to content

Comments

Treat warnings as errors#8006

Merged
josevalim merged 1 commit intomasterfrom
mm/compiler-warnings-errors
Aug 23, 2018
Merged

Treat warnings as errors#8006
josevalim merged 1 commit intomasterfrom
mm/compiler-warnings-errors

Conversation

@michalmuskala
Copy link
Member

@michalmuskala michalmuskala commented Jul 29, 2018

No description provided.

@josevalim
Copy link
Member

josevalim commented Jul 29, 2018

@michalmuskala I think we should always enable them then.

@michalmuskala michalmuskala force-pushed the mm/compiler-warnings-errors branch from b4ec6ef to 53efaa4 Compare August 4, 2018 11:25
@michalmuskala michalmuskala changed the title Treat warnings as errors on CI Treat warnings as errors Aug 4, 2018
@michalmuskala michalmuskala force-pushed the mm/compiler-warnings-errors branch from 53efaa4 to 527c078 Compare August 4, 2018 11:26
@michalmuskala michalmuskala force-pushed the mm/compiler-warnings-errors branch from 527c078 to f7cf1b6 Compare August 4, 2018 11:31
umamaistempo
umamaistempo approved these changes Aug 23, 2018
View reviewed changes
Copy link
Contributor

@umamaistempo umamaistempo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make Travis sad while making me happy. I like it

Edit: This will force us to always make "valid" code, requiring us to update code that uses soft-deprecated operations, which is great

Edit2: By doing so, the CI will not be allowed to test soft-deprecated code as they emit warnings ? 🤔 that is bad

@josevalim
Copy link
Member

josevalim commented Aug 23, 2018

Edit2: By doing so, the CI will not be allowed to test soft-deprecated code as they emit warnings ? 🤔 that is bad

This covers only compilation, we should be fine for the tests themselves!

@josevalim josevalim merged commit c76c5d6 into master Aug 23, 2018
@josevalim
Copy link
Member

josevalim commented Aug 23, 2018

❤️ 💚 💙 💛 💜

@josevalim josevalim deleted the mm/compiler-warnings-errors branch August 23, 2018 21:47
@zkessin
Copy link

zkessin commented Aug 26, 2018

there should be a way to say only in my code and not in mix dependencies

@fertapric
Copy link
Member

fertapric commented Aug 26, 2018 •
edited
Loading

@zkessin I think this is only applied when compiling the Elixir codebase. Personal Elixir projects are not affected by this PR.

@zkessin
Copy link

zkessin commented Aug 27, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@umamaistempo umamaistempo umamaistempo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@michalmuskala @josevalim @zkessin @fertapric @umamaistempo